Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Remove tests for not supported gevent 1.3 #644

Merged
merged 3 commits into from
Oct 11, 2018
Merged

[tests] Remove tests for not supported gevent 1.3 #644

merged 3 commits into from
Oct 11, 2018

Conversation

labbati
Copy link
Member

@labbati labbati commented Oct 11, 2018

No description provided.

@brettlangdon
Copy link
Member

Can we update gevent in this doc to say >= 1.0 < 1.3 https://github.com/DataDog/dd-trace-py/blob/88a9278232a533cfdf7b9e4590a09aaf9a7afa7d/docs/index.rst ?

@brettlangdon
Copy link
Member

Otherwise, this looks great!

@labbati labbati added this to the 0.15.0 milestone Oct 11, 2018
Kyle-Verhoog
Kyle-Verhoog requested changes Oct 11, 2018
View reviewed changes
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add to docs/index.rst that we support up to version 1.3.

@labbati labbati force-pushed the labbati/remove-gevent1.3-tests branch from 07c2eed to eb81712 Compare October 11, 2018 15:47
brettlangdon
brettlangdon previously approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once CI shows green, this is good from me 👍

Kyle-Verhoog
Kyle-Verhoog previously approved these changes Oct 11, 2018
View reviewed changes
@brettlangdon brettlangdon dismissed stale reviews from Kyle-Verhoog and themself via a9a10e1 October 11, 2018 16:06
@palazzem palazzem merged commit 87b9ff7 into master Oct 11, 2018
@palazzem palazzem deleted the labbati/remove-gevent1.3-tests branch October 11, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@labbati @brettlangdon @Kyle-Verhoog @palazzem