[core] Update config to allow configuration before patching #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if we tried to set a config setting before the contrib module was imported we would receive an error that the integration key did not exist. With this new approach we are allowing any integration setting to be configured by the user, whenever they want and then when we call `config._add()` in the contrib module, we will merge the settings with any existing settings, keeping those that already exist. We have also added a Config.__repr__
|
An explanation of the current problem is probably good too... If we tried to do: import ddtrace
ddtrace.patch_all(requests=True)
ddtrace.config.requests['split_by_domain'] = TrueWe would receive an exception, because With these changes, the above will work, and when we |
labbati
requested changes
Oct 16, 2018
palazzem
previously approved these changes
Oct 16, 2018
Kyle-Verhoog
previously approved these changes
Oct 16, 2018
| ), | ||
| ), | ||
| )) | ||
| eq_(self.config.requests['a']['b']['c'], True) |
brettlangdon
dismissed stale reviews from Kyle-Verhoog and palazzem
via
c7af42a
|
CI is green, Github rate limited CircleCI again 🙄 |
labbati
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we tried to set a config setting before the contrib module was imported
we would receive an error that the integration key did not exist.
With this new approach we are allowing any integration setting to be configured by
the user, whenever they want and then when we call
config._add()in the contribmodule, we will merge the settings with any existing settings, keeping those that
already exist.
We have also added a
Config.__repr__