Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] ensure we are running tests.contrib.test_utils #678

Merged
merged 5 commits into from Oct 25, 2018

Conversation

brettlangdon
Copy link
Member

We were not running these tests in CircleCI before.

Kyle-Verhoog
Kyle-Verhoog previously approved these changes Oct 25, 2018
docker:
- *test_runner
environment:
TOX_SKIP_DIST: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, whoops, I probably copy/pasta from a bad place

@brettlangdon brettlangdon added this to the 0.16.0 milestone Oct 25, 2018
@brettlangdon
Copy link
Member Author

... finally...

@Kyle-Verhoog think I need another ✅ it resets on commit/push.

Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@brettlangdon brettlangdon changed the base branch from master to 0.16-dev October 25, 2018 18:24
@brettlangdon brettlangdon merged commit cc8cab1 into 0.16-dev Oct 25, 2018
@Kyle-Verhoog Kyle-Verhoog deleted the brettlangdon/run.utils.tests branch October 31, 2018 11:22
brettlangdon added a commit that referenced this pull request Nov 8, 2018
* [tests] ensure we are running tests.contrib.test_utils

* [tests] remove unnecessary environment variable

* [tests] add test_utils to list of tests to run

* [tests] add test_utils as requirement for wait_all_tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants