[httplib, requests] Sanitize urls in span metadata #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
requested changes
Nov 2, 2018
brettlangdon
requested changes
Nov 2, 2018
There was a problem hiding this comment.
we also want to have a test case for requests in here: https://github.com/DataDog/dd-trace-py/blob/master/tests/contrib/requests/test_requests.py
majorgreys
changed the title
brettlangdon
requested changes
Nov 5, 2018
| @@ -55,6 +53,15 @@ def _wrap_request(func, instance, args, kwargs): | |||
| url = kwargs.get('url') or args[1] | |||
| headers = kwargs.get('headers', {}) | |||
| parsed_uri = parse.urlparse(url) | |||
| # sanitize url of query | |||
| sanitized_url = parse.urlunparse(( | |||
There was a problem hiding this comment.
👍
I was originally thinking just parsed_uri.path or something, but this is much better.
|
might need to update from |
brettlangdon
pushed a commit
that referenced
this pull request
Nov 8, 2018
* [httplib] Strip all but path from url * [httplib] Fix tests * [requests] Sanitize url * [httplib] Add comment * Correct comment * Make httlib and requests consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
urlparsein Python 2 and Python 3 standard library to only set the path (without parameters and query string) in thehttp.urlmetadata.