[core] Add global tracer tags #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
commented
Nov 8, 2018
There was a problem hiding this comment.
small suggestion, but otherwise looks good to me.
Would like to get @Kyle-Verhoog's review on here as well.
Kyle-Verhoog
approved these changes
Nov 13, 2018
brettlangdon
approved these changes
Nov 13, 2018
brettlangdon
approved these changes
Nov 13, 2018
Kyle-Verhoog
approved these changes
Nov 14, 2018
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Nov 23, 2018
* Initial attempt at global tags * Use patch module list approach for global trace tags * Add sdist flag to testrunner start * remove environment variable * [ddtracerun] Fix tests for global tags * Remove type casting for global tags * Use partition and fix test * Rename to `DD_TRACE_GLOBAL_TAGS` * Prefer single quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should offer an environment variable for global tags, for instance via
DD_TRACE_TAGS.