[ci] reorganize CircleCI workflows #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - wait_all_tests: | ||
| requires: | ||
| - build_docs | ||
| - flake8 |
There was a problem hiding this comment.
can probably get rid of this requirement now?
There was a problem hiding this comment.
I wasn't sure about that... but I figured worse case keep it in here in case we re-org again and forget to add it back in 😆
If you have a stronger opinion about it being removed, happy to, no real reason other than ☝️
Kyle-Verhoog
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
deploy_experimentalon all*-devbranches0.16-devso we don't need to merge intomasterin order to deploy to stagingflake8taskrequires: flake8for each and every job, but will be nice to not destroy our parallelism if linting fails