[core] Allow DD_AGENT_HOST and DD_TRACE_AGENT_PORT env variables #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
reviewed
Nov 12, 2018
| DEFAULT_HOSTNAME = environ.get('DATADOG_TRACE_AGENT_HOSTNAME', 'localhost') | ||
| DEFAULT_PORT = 8126 | ||
| DEFAULT_HOSTNAME = environ.get('DD_AGENT_HOST', environ.get('DATADOG_TRACE_AGENT_HOSTNAME', 'localhost')) | ||
| DEFAULT_PORT = int(environ.get('DD_TRACE_AGENT_PORT', 8126)) |
There was a problem hiding this comment.
Do we have a test for this code path? Such as initializing a new tracer after setting the env vars without using ddtrace-run?
Kyle-Verhoog
previously approved these changes
Nov 13, 2018
There was a problem hiding this comment.
To prevent regressions we can add the test @palazzem suggested. Looks good otherwise.
palazzem
suggested changes
Nov 13, 2018
|
@palazzem I think if I understood what you were looking for correctly, I updated the tests to also run the same hostname check runner, but without using |
Kyle-Verhoog
approved these changes
Nov 14, 2018
palazzem
approved these changes
Nov 14, 2018
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Nov 23, 2018
* [core] Allow DD_AGENT_HOST and DD_TRACE_AGENT_PORT env variables * [core] test different tracer port and running without ddtrace-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help support desired containerization onboarding improvements we need to support
DD_AGENT_HOSTandDD_TRACE_AGENT_PORTenvironment variables for configuration.These changes are the minimal viable changes needed to support these variables. It isn't the most clean, using something like
get_env()would be better, but we decided to get this out the door since @Kyle-Verhoog has a task to work on standardizing ourDD_*variables.