Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use small circleci resource class for all jobs #710

Merged
merged 4 commits into from
Nov 14, 2018

Conversation

Kyle-Verhoog
Copy link
Member

As per title. This should help minimize costs on circleci and shouldn't come at too much a performance hit since the tests are not run in parallel.

Unfortunately it doesn't look like we can set a default resource class for all jobs, so we have to specify one for each job 馃槙.

@Kyle-Verhoog Kyle-Verhoog added this to the 0.17.0 milestone Nov 14, 2018
@brettlangdon
Copy link
Member

We should be able to do something like this:

default_job: &default_job
    docker:
        - *test_runner
    resource_class: *resource_class


jobs:
    flake8:
        <<: *default_job
        steps:
          - ...

YAML has some issues with block inheritance though, since if you wanted to add to docker: your changes overwrite those from default_job instead of merging.

default_job: &default_job
    docker:
        - *test_runner
    resource_class: *resource_class

jobs:
    flake8:
      <<: *default_job
      docker:
          - *test_runner
          - <custom thing>
      steps:
          - 

This isn't a required change to make in this PR, just an observation on the weirdness of YAML.

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks! and the tests pass too!

@Kyle-Verhoog Kyle-Verhoog merged commit 0688839 into 0.17-dev Nov 14, 2018
@Kyle-Verhoog Kyle-Verhoog deleted the kyle-verhoog/circleci-worker branch November 14, 2018 14:43
Kyle-Verhoog added a commit that referenced this pull request Nov 23, 2018
* [ci] use small resource class for all jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants