Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requests] Add another split_by_domain test #713

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Conversation

majorgreys
Copy link
Collaborator

To confirm that the service is set by the domain and port of a request and the path is not included.

@majorgreys majorgreys changed the base branch from master to 0.17-dev November 14, 2018 20:21
brettlangdon
brettlangdon previously approved these changes Nov 14, 2018
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending remove of unused line, lgtm

@brettlangdon brettlangdon added this to the 0.17.0 milestone Nov 14, 2018
@majorgreys majorgreys merged commit 33069c4 into 0.17-dev Nov 14, 2018
@majorgreys majorgreys deleted the tahir/requests.test branch November 14, 2018 21:18
Kyle-Verhoog pushed a commit that referenced this pull request Nov 23, 2018
* Add another split_by_domain test

* Forgot to remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants