Enable priority sampling by default #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
commented
Dec 11, 2018
palazzem
suggested changes
Dec 11, 2018
brettlangdon
commented
Dec 12, 2018
palazzem
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Great, thank you very much!
For reference, we're targeting automatically endpoint v0.4 with a fallback system that downgrades the connection to endpoint v0.3 if missing (404). This change in the default is reasonably safe.
Also, our Agent added the Priority Sampling endpoint with this PR: https://github.com/DataDog/datadog-trace-agent/pull/310/files#diff-e8961f81006d547c70ab424318805bbaR99
that landed on this release (3 Nov 2017): https://github.com/DataDog/datadog-trace-agent/releases/tag/5.19.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable priority sampling by default now.