[tools] Add confirmation to 'rake pypi:release' task #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These checks might be ok for an initial trial, but there is a chance they are a little too aggressive and add too much friction, happy to readjust in the future as well. |
Kyle-Verhoog
previously approved these changes
Jan 25, 2019
| print " To proceed please type the version '#{ddtrace_version}': " | ||
| $stdout.flush | ||
|
|
||
| abort if $stdin.gets.to_s.strip.downcase != ddtrace_version |
Kyle-Verhoog
approved these changes
Jan 25, 2019
Merged
brettlangdon
added a commit
that referenced
this pull request
Jan 29, 2019
* [tests] limit grpcio version to >=1.8.0,<1.18.0 * [tools] Add confirmation to 'rake pypi:release' task (#791) * [tools] Add confirmation to 'rake pypi:release' task * check if we are on tagged version instead * [core] Call HTTPResponse.read() before HTTPConnection.close() (#800) * [core] Call HTTPResponse.read() before HTTPConnection.close() * engrish * add reason and msg as well * use API.Response in integration tests * limit version of grpc * ensure we have regression test * move API.Response to just Response * result_traces/services => traces/services_response * fix logging error message tests * fix test for python 2.7 * Update ddtrace/writer.py Co-Authored-By: brettlangdon <me@brett.is> * Update ddtrace/api.py Co-Authored-By: brettlangdon <me@brett.is> * fix integration tests * Bump version to 0.20.2 (#803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in two quick checks/confirmations to the
rake pypi:releasetask.The first check looks to see if the current commit is associated with the tag for
v#{__version__}, if not it asks the user to confirm that they want to proceed.The second check will always show, warning the user that this action cannot be undone and asks them to confirm by typing in the current (should be released) version of
ddtrace.Example: