Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add __init__.py to peer_service module #8765

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Mar 26, 2024

Fixes an issue where importing ddtrace.internal.peer_service would fail raising an ImportError

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede changed the title fix: add __init__.py to peer_service module fix: add __init__.py to peer_service module Mar 26, 2024
@gnufede gnufede marked this pull request as ready for review March 26, 2024 14:15
@gnufede gnufede requested review from a team as code owners March 26, 2024 14:15
@gnufede gnufede requested a review from a team as a code owner March 26, 2024 14:30
@gnufede gnufede marked this pull request as draft March 26, 2024 14:34
@gnufede gnufede force-pushed the gnufede/fix-peer_service-module branch from 467282b to 98be3b6 Compare March 26, 2024 14:41
@gnufede gnufede marked this pull request as ready for review March 26, 2024 14:42
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Mar 26, 2024

Datadog Report

Branch report: gnufede/fix-peer_service-module
Commit report: 4fba432
Test service: dd-trace-py

✅ 0 Failed, 203 Passed, 732 Skipped, 7m 26.98s Total duration (32m 26.05s time saved)

@gnufede gnufede enabled auto-merge (squash) March 26, 2024 14:43
@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2024

Benchmarks

Benchmark execution time: 2024-03-26 16:23:55

Comparing candidate commit 4fba432 in PR branch gnufede/fix-peer_service-module with baseline commit d8ebea7 in branch main.

Found 3 performance improvements and 3 performance regressions! Performance is the same for 161 metrics, 9 unstable metrics.

scenario:httppropagationextract-empty_headers

  • 🟥 max_rss_usage [+717.828KB; +882.479KB] or [+3.420%; +4.205%]

scenario:httppropagationextract-full_t_id_datadog_headers

  • 🟥 max_rss_usage [+708.928KB; +779.559KB] or [+3.354%; +3.688%]

scenario:httppropagationextract-wsgi_invalid_priority_header

  • 🟥 max_rss_usage [+624.628KB; +802.009KB] or [+2.955%; +3.794%]

scenario:httppropagationextract-wsgi_invalid_span_id_header

  • 🟩 max_rss_usage [-774.000KB; -569.897KB] or [-3.537%; -2.604%]

scenario:httppropagationextract-wsgi_medium_header_no_matches

  • 🟩 max_rss_usage [-669.834KB; -532.751KB] or [-3.059%; -2.433%]

scenario:httppropagationextract-wsgi_valid_headers_basic

  • 🟩 max_rss_usage [-998.464KB; -678.029KB] or [-4.559%; -3.096%]

@gnufede gnufede merged commit 630b659 into main Mar 26, 2024
148 of 149 checks passed
@gnufede gnufede deleted the gnufede/fix-peer_service-module branch March 26, 2024 16:37
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
Fixes an issue where importing `ddtrace.internal.peer_service` would
fail raising an `ImportError`

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 630b659)
gnufede added a commit that referenced this pull request Apr 3, 2024
Backport 630b659 from #8765 to 2.7.

Fixes an issue where importing `ddtrace.internal.peer_service` would
fail raising an `ImportError`


## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Federico Mon <federico.mon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants