Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add __init__.py to ddtrace.appsec._iast._patches module #8774

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Mar 26, 2024

Fixes an issue where importing ddtrace.internal.peer_service would fail raising an ImportError

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede marked this pull request as ready for review March 26, 2024 16:21
@gnufede gnufede requested review from a team as code owners March 26, 2024 16:21
@gnufede gnufede changed the title fix: add __init__.py to ddtrace.appsec._iast._patches module fix: add __init__.py to ddtrace.appsec._iast._patches module Mar 26, 2024
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Mar 26, 2024

Datadog Report

Branch report: gnufede/fix-module-ddtrace-iast-patches
Commit report: 0c38582
Test service: dd-trace-py

✅ 0 Failed, 378 Passed, 111087 Skipped, 16m 2.23s Total duration (1h 34m 41.57s time saved)

@gnufede gnufede enabled auto-merge (squash) March 26, 2024 16:34
@gnufede gnufede merged commit 31edc72 into main Mar 26, 2024
78 of 79 checks passed
@gnufede gnufede deleted the gnufede/fix-module-ddtrace-iast-patches branch March 26, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants