Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(telemetry): expect observed test result #8807

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Mar 29, 2024

Improves the reliability of the test suite by limiting the set of events retrieved in this telemetry test and expecting the occasionally-observed number of events.

The test agent session is shared between many tests, and it's not reliable at resetting itself between tests. The more complete and permanent fix to these issues is to make the test agent session reliable.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner March 29, 2024 14:07
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 29, 2024
tests/telemetry/test_writer.py Show resolved Hide resolved
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Mar 29, 2024

Datadog Report

Branch report: emmett.butler/telemetry-accc-flake
Commit report: 2bd0712
Test service: dd-trace-py

✅ 0 Failed, 203 Passed, 223 Skipped, 20.5s Total duration (1m 6.68s time saved)

@emmettbutler emmettbutler enabled auto-merge (squash) March 29, 2024 14:36
@emmettbutler emmettbutler merged commit 907b7e8 into main Mar 29, 2024
43 of 45 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/telemetry-accc-flake branch March 29, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants