-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiling): tag serialisation in HTTP exporter [backport 2.8] #9042
Conversation
Ensure that the HTTP exporter does not fail to serialise the tags. Addresses #8996. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [ ] Title is accurate - [ ] All changes are related to the pull request's stated goal - [ ] Description motivates each change - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [ ] Testing strategy adequately addresses listed risks - [ ] Change is maintainable (easy to change, telemetry, documentation) - [ ] Release note makes sense to a user of the library - [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 0bacde0)
Datadog ReportBranch report: ✅ 0 Failed, 42 Passed, 1008 Skipped, 6m 58.36s Total duration (1h 15m 12s time saved) |
BenchmarksBenchmark execution time: 2024-04-22 09:44:23 Comparing candidate commit c009fd6 in PR branch Found 4 performance improvements and 7 performance regressions! Performance is the same for 190 metrics, 9 unstable metrics. scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match
scenario:httppropagationextract-full_t_id_datadog_headers
scenario:httppropagationextract-invalid_priority_header
scenario:httppropagationextract-wsgi_empty_headers
scenario:httppropagationextract-wsgi_large_header_no_matches
scenario:httppropagationextract-wsgi_large_valid_headers_all
scenario:httppropagationextract-wsgi_medium_header_no_matches
scenario:httppropagationextract-wsgi_medium_valid_headers_all
scenario:httppropagationextract-wsgi_valid_headers_basic
scenario:httppropagationinject-with_tags_invalid
scenario:httppropagationinject-with_tags_max_size
|
Backport 0bacde0 from #9032 to 2.8.
Ensure that the HTTP exporter does not fail to serialise the tags.
Addresses #8996.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist