Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #9113, #9114, #9085 #9230

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: revert #9113, #9114, #9085 #9230

merged 3 commits into from
May 10, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented May 10, 2024

Reverting the following IAST PRs: #9113, #9114, #9085

They will be re-introduced in 2.10 after some investigation, but reverting for now to un-block the 2.9.0 release pipeline.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label May 10, 2024
@erikayasuda erikayasuda changed the title Erikayasuda/2.9revert fix: revert #9113, #9114, #9085 May 10, 2024
@erikayasuda erikayasuda marked this pull request as ready for review May 10, 2024 17:10
@erikayasuda erikayasuda requested a review from a team as a code owner May 10, 2024 17:10
@brettlangdon brettlangdon enabled auto-merge (squash) May 10, 2024 17:11
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: erikayasuda/2.9revert
Commit report: dcff08c
Test service: dd-trace-py

✅ 0 Failed, 118066 Passed, 56097 Skipped, 2h 56m 54.7s Total duration (7h 33m 16.06s time saved)

@brettlangdon brettlangdon merged commit 3c7d1d1 into 2.9 May 10, 2024
177 of 197 checks passed
@brettlangdon brettlangdon deleted the erikayasuda/2.9revert branch May 10, 2024 17:25
juanjux added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants