Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): extract openai/llmobs tests to separate file #9397

Merged
merged 6 commits into from
May 29, 2024

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented May 27, 2024

This PR moves LLMObs tests from the test_openai_v0/v1.py files into test_openai_llmobs.py to ease maintainability for LLMObs tests in the future. No functionality is added/removed.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label May 27, 2024
@Yun-Kim Yun-Kim force-pushed the yunkim/llmobs-patch-only-llms branch from a72aa9e to dee98a9 Compare May 27, 2024 21:08
@Yun-Kim Yun-Kim force-pushed the yunkim/llmobs-move-openai-tests branch from b701e11 to dd4a85b Compare May 27, 2024 21:09
@Yun-Kim Yun-Kim force-pushed the yunkim/llmobs-patch-only-llms branch from dee98a9 to 1a1ae20 Compare May 27, 2024 21:33
@Yun-Kim Yun-Kim changed the title chore(llmobs): Extract openai/llmobs tests to separate file chore(llmobs): extract openai/llmobs tests to separate file May 28, 2024
Base automatically changed from yunkim/llmobs-patch-only-llms to main May 28, 2024 18:45
@datadog-datadog-prod-us1
Copy link

Software Composition Analysis

We found vulnerabilities in the following libraries (compared df5b752 against a1a0ea7):

@Yun-Kim Yun-Kim marked this pull request as ready for review May 28, 2024 18:58
@Yun-Kim Yun-Kim requested a review from a team as a code owner May 28, 2024 18:58
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 28, 2024

Datadog Report

Branch report: yunkim/llmobs-move-openai-tests
Commit report: d6a8759
Test service: dd-trace-py

✅ 0 Failed, 456 Passed, 864 Skipped, 27m 45.12s Total duration (14m 7.23s time saved)

@Yun-Kim Yun-Kim enabled auto-merge (squash) May 28, 2024 19:17
@Yun-Kim Yun-Kim merged commit a864142 into main May 29, 2024
92 checks passed
@Yun-Kim Yun-Kim deleted the yunkim/llmobs-move-openai-tests branch May 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants