feat(llmobs): modify integration patch behavior in llmobs.enable() #9398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Kim
added
the
changelog/no-changelog
Yun-Kim
force-pushed
the
yunkim/llmobs-patch-only-llms
branch
from
a72aa9e
to
dee98a9
Compare
Yun-Kim
force-pushed
the
yunkim/llmobs-patch-only-llms
branch
from
dee98a9
to
1a1ae20
Compare
Datadog ReportBranch report: ✅ 0 Failed, 2397 Passed, 1090 Skipped, 57m 36.68s Total duration (29m 32.84s time saved) |
17 tasks
Yun-Kim
changed the title
sabrenner
approved these changes
May 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2024
…9398) This PR changes the LLMObs.enable() argument integrations list of integrations to enable to --> integrations_enabled a boolean flag whether or not the LLM integrations should be patched. Previously we could use LLMObs.enable(integrations=[...]) to enable which LLMObs integrations to patch, but this is unnecessary functionality that is already supported by ddtrace. Users should just use ddtrace.patch_all()/ddtrace.patch() instead. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x ] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit a1a0ea7)
16 tasks
Yun-Kim
added a commit
that referenced
this pull request
May 29, 2024
…ackport 2.9] (#9434) Backport a1a0ea7 from #9398 to 2.9. This PR changes the LLMObs.enable() argument integrations list of integrations to enable to --> integrations_enabled a boolean flag whether or not the LLM integrations should be patched. Previously we could use LLMObs.enable(integrations=[...]) to enable which LLMObs integrations to patch, but this is unnecessary functionality that is already supported by ddtrace. Users should just use ddtrace.patch_all()/ddtrace.patch() instead. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x ] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the LLMObs.enable() argument integrations list of integrations to enable to --> integrations_enabled a boolean flag whether or not the LLM integrations should be patched.
Previously we could use LLMObs.enable(integrations=[...]) to enable which LLMObs integrations to patch, but this is unnecessary functionality that is already supported by ddtrace. Users should just use ddtrace.patch_all()/ddtrace.patch() instead.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist