Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Profiling): add infrastructure for supporting timeline, but timeline isn't supported yet #9440

Merged
merged 37 commits into from
Jun 10, 2024

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented May 29, 2024

Next week I'll finally add support for testing some of these new interface. Moreover, at the current time this stuff is pretty much only for internal testing, so I'll document when we're closer to going public.

The, uh, framing for this is kind of weird. I'm sorry about that.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@danielsn
Copy link
Contributor

@emmettbutler This is a PR we are hoping to get into the 2.10RC

@sanchda sanchda marked this pull request as ready for review June 7, 2024 20:37
@sanchda sanchda requested review from a team as code owners June 7, 2024 20:37
@sanchda sanchda requested a review from emmettbutler June 7, 2024 20:37
@sanchda sanchda added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 7, 2024
@sanchda sanchda changed the title feat(Profiling): add preliminary timeline support chore(Profiling): add infrastructure for supporting timeline, but timeline isn't supported yet Jun 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 7, 2024

Benchmarks

Benchmark execution time: 2024-06-10 18:05:56

Comparing candidate commit dd80928 in PR branch sanchda/add_timeline_ddup with baseline commit e859b8d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@sanchda sanchda enabled auto-merge (squash) June 10, 2024 16:03
Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

Copy link
Contributor

@danielsn danielsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions. LGTM

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 10, 2024

Datadog Report

Branch report: sanchda/add_timeline_ddup
Commit report: aecbeba
Test service: dd-trace-py

✅ 0 Failed, 561 Passed, 987 Skipped, 41m 40.48s Total duration (25m 12.75s time saved)

@sanchda sanchda merged commit 360b469 into main Jun 10, 2024
106 of 111 checks passed
@sanchda sanchda deleted the sanchda/add_timeline_ddup branch June 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants