-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Profiling): add infrastructure for supporting timeline, but timeline isn't supported yet #9440
Conversation
…ce-py into sanchda/add_timeline_ddup
ddtrace/internal/datadog/profiling/stack_v2/src/stack_renderer.cpp
Outdated
Show resolved
Hide resolved
@emmettbutler This is a PR we are hoping to get into the 2.10RC |
BenchmarksBenchmark execution time: 2024-06-10 18:05:56 Comparing candidate commit dd80928 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions. LGTM
ddtrace/internal/datadog/profiling/dd_wrapper/include/sample.hpp
Outdated
Show resolved
Hide resolved
ddtrace/internal/datadog/profiling/dd_wrapper/src/interface.cpp
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 561 Passed, 987 Skipped, 41m 40.48s Total duration (25m 12.75s time saved) |
Next week I'll finally add support for testing some of these new interface. Moreover, at the current time this stuff is pretty much only for internal testing, so I'll document when we're closer to going public.
The, uh, framing for this is kind of weird. I'm sorry about that.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist