-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: handle RemoteDisconnected in snapshot tests #9464
Conversation
handle Disconnected errors in snapshot runner
Datadog ReportBranch report: ✅ 0 Failed, 119390 Passed, 58867 Skipped, 4h 9m 40.39s Total duration (3h 19m 32.86s time saved) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9464 +/- ##
===========================================
- Coverage 75.91% 10.30% -65.61%
===========================================
Files 1314 1284 -30
Lines 124462 122626 -1836
===========================================
- Hits 94482 12642 -81840
- Misses 29980 109984 +80004 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit question
BenchmarksBenchmark execution time: 2024-06-10 19:40:25 Comparing candidate commit 1e5f1da in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny suggestion, otherwise lgtm
This change handles errors like this in the snapshot test harness by retrying requests. This makes sense because we always expect such errors to be transient, and if they happen not to be the test will eventually time out.
This change also marks a few recently observed unreliable failures (one, two) and adds an exception condition to a Django test that recently exhibited it.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist