-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add IAST smoke tests for common packages #9469
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Datadog ReportBranch report: ✅ 0 Failed, 176131 Passed, 1252 Skipped, 11h 21m 50.01s Total duration (7m 16.54s time saved) |
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
This can be already reviewed, follow up PRs adding more smoke tests for more packages will be smaller. If you want to check only the important bits that changed (this is from a previous PR from Alberto that was merged and then pulled back because the packages were not installed on a virtualenv and had some side-effects with other tests), ignoring the auto generated or semi auto generated files, just check |
BenchmarksBenchmark execution time: 2024-06-12 08:34:46 Comparing candidate commit 9345f50 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
Co-authored-by: Federico Mon <federico.mon@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
riotfile changes lgtm
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
Description
Adds smoke + small integration tests of the most used modules. Still in progress, will be split into several PRs. Originally by @avara1986
Changes since the previous reverted PR:
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist