-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(asm): standalone asm propagation #9482
chore(asm): standalone asm propagation #9482
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 118967 Passed, 55776 Skipped, 3h 33m 53.16s Total duration (5h 11m 8.11s time saved) |
BenchmarksBenchmark execution time: 2024-06-10 14:23:24 Comparing candidate commit ce88f01 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9482 +/- ##
===========================================
- Coverage 75.88% 10.27% -65.61%
===========================================
Files 1315 1285 -30
Lines 124706 123093 -1613
===========================================
- Hits 94633 12650 -81983
- Misses 30073 110443 +80370 ☔ View full report in Codecov by Sentry. |
Description:
ASM: adds Standalone ASM distributed propagation changes as described in "RFC: Standalone ASM billing V2".
For the full picture of this feature, see: #9211 , #9444 and #9445
See also System Tests related changes: DataDog/system-tests#2522
Details:
The main change is that if ASM Standalone is enabled, propagation of distributed spans would reset (from upstream) unless they are part of a distributed span where there are AppSec events (signaled through the propagation tag _dd.p.appsec: 1).
It will also cut propagation downstream if there are no appsec events in the current or upstream spans.
Notice that AppSec events trigger a force keep, and that takes precedence over the received propagation in this PR.
Also notice that most tests start by creating a first span without an appsec event. This is due to the fact that ASM Standalone needs to maintain a minimum rate of 1 trace per minute regardless of upstream propagation or appsec events present, so that way we are not affected by that rate in the test.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist