Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install mock for encoders profile #9485

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 5, 2024

This change attempts to resolve main-branch CI failures like this one by installing mock in the profile's environment.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner June 5, 2024 19:22
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 5, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/pipmock
Commit report: cac6ab1
Test service: dd-trace-py

✅ 0 Failed, 123570 Passed, 54495 Skipped, 4h 24m 34.48s Total duration (5h 47m 20.29s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2024

Benchmarks

Benchmark execution time: 2024-06-10 17:13:19

Comparing candidate commit eaf5c70 in PR branch emmett.butler/pipmock with baseline commit e859b8d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 151 metrics, 9 unstable metrics.

@emmettbutler emmettbutler enabled auto-merge (squash) June 7, 2024 12:02
@emmettbutler emmettbutler merged commit 1e22549 into main Jun 10, 2024
94 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/pipmock branch June 10, 2024 17:17
tabgok pushed a commit that referenced this pull request Jul 11, 2024
This change attempts to resolve main-branch CI failures like [this
one](https://github.com/DataDog/dd-trace-py/actions/runs/9387454355/job/25850411962)
by installing `mock` in the profile's environment.

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants