chore: use separate directory for testrunner container riot #9486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality-of-life improvement to separate the
.riot
directory used when inside atestrunner
container from the.riot
directory outside the container. This is achieved simply by changing the bind-mounted directory when the container is started withdocker-compose
.This is primarily because the
testrunner
'sriot
envs will have symlinks to Python binaries in/root/
which are incorrect outside of the container.This makes it less likely that there would be issues when developers mix running tests inside the container with using workflow-related
riot
commands outside of the container.Two notable locations where
.riot
remains untouched:scripts/compile-and-prune-test-requirements
: this needs to run outside of the container in order to modify the proper filesscripts/run-test-suite
: this would either run outside or inside the container (although I don't think anyone uses it manually anyway since it requires a bit of setup)Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist