Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib-injection): post-injection telemetry #9489

Merged
merged 130 commits into from
Jun 11, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 6, 2024

This change adds information to the "app started" telemetry event that indicates some of the specifics about the library-injection code path:

  • whether it was hit at all
  • whether it successfully performed library injection
  • whether the user specified that injection should be "forced" past guardrails

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner June 6, 2024 12:20
@emmettbutler emmettbutler requested review from brettlangdon and removed request for a team June 6, 2024 12:20
@emmettbutler emmettbutler marked this pull request as draft June 6, 2024 12:20
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 6, 2024

Datadog Report

Branch report: emmett.butler/more-injection-telemetry
Commit report: b70e80e
Test service: dd-trace-py

✅ 0 Failed, 120969 Passed, 57288 Skipped, 4h 16m 37.77s Total duration (3h 30m 53.33s time saved)

@emmettbutler emmettbutler changed the title send more detailed telemetry about lib-injection once the library has… chore(lib-injection): post-injection telemetry Jun 6, 2024
@emmettbutler emmettbutler marked this pull request as ready for review June 6, 2024 12:57
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 6, 2024
Base automatically changed from emmett.butler/injection-telemetry-tests to main June 11, 2024 15:04
@emmettbutler emmettbutler requested a review from a team as a code owner June 11, 2024 15:04
@emmettbutler emmettbutler enabled auto-merge (squash) June 11, 2024 15:17
@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Benchmarks

Benchmark execution time: 2024-06-11 16:38:14

Comparing candidate commit 2389ac4 in PR branch emmett.butler/more-injection-telemetry with baseline commit c5daad9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 219 metrics, 11 unstable metrics.

@emmettbutler emmettbutler merged commit 2e237a7 into main Jun 11, 2024
200 of 206 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/more-injection-telemetry branch June 11, 2024 17:00
Copy link

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport-9489-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2e237a7ee8e23ff1d96285e6e70c364a103e098a
# Push it to GitHub
git push --set-upstream origin backport-9489-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport-9489-to-2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.10 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants