Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: mark unreliable langchain_community tests #9490

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 6, 2024

This change marks some unreliable tests in the langchain_community suite. Some of these had been recently unmarked in ecc56cf, but it seems like they still have some underlying unreliability (example).

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 6, 2024
@emmettbutler emmettbutler requested a review from a team as a code owner June 6, 2024 13:31
@emmettbutler emmettbutler requested a review from Yun-Kim June 6, 2024 13:31
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 6, 2024

Datadog Report

Branch report: emmett.butler/flaky-langchain
Commit report: 96a67f4
Test service: dd-trace-py

✅ 0 Failed, 310 Passed, 140 Skipped, 8m 16.7s Total duration (2m 12.28s time saved)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 10.29%. Comparing base (3bc3051) to head (b60ff60).

Files Patch % Lines
...ests/contrib/langchain/test_langchain_community.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9490       +/-   ##
===========================================
- Coverage   69.41%   10.29%   -59.13%     
===========================================
  Files        1315     1285       -30     
  Lines      124706   122866     -1840     
===========================================
- Hits        86567    12645    -73922     
- Misses      38139   110221    +72082     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some investigating and it looks like the underlying issue is a version issue with vcrpy (reading cassette files). I'm good to mark these tests as flaky for now, but will be pinning vcrpy in a future PR which should hopefully remove the flakiness.

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2024

Benchmarks

Benchmark execution time: 2024-06-10 15:33:32

Comparing candidate commit 96a67f4 in PR branch emmett.butler/flaky-langchain with baseline commit 20e87ca in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 96 metrics, 0 unstable metrics.

@emmettbutler emmettbutler enabled auto-merge (squash) June 7, 2024 12:03
@emmettbutler emmettbutler merged commit e859b8d into main Jun 10, 2024
124 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/flaky-langchain branch June 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants