chore(llmobs): migrate span payload structure to meet new evp updates #9546
+93
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 898 Passed, 39489 Skipped, 39m 29.88s Total duration (56m 18.22s time saved) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9546 +/- ##
===========================================
- Coverage 69.05% 10.17% -58.88%
===========================================
Files 1336 1304 -32
Lines 126231 124193 -2038
===========================================
- Hits 87168 12640 -74528
- Misses 39063 111553 +72490 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-17 20:39:20 Comparing candidate commit 63e2136 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
Yun-Kim
added
the
changelog/no-changelog
sabrenner
approved these changes
Jun 17, 2024
tabgok
pushed a commit
that referenced
this pull request
Jul 11, 2024
…#9546) This PR updates the structure of LLMObs span payloads to meet the new LLMObs evp public API requirements. Existing tests should cover this change, and this is a completely internal change meaning there are no public-facing changes. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the structure of LLMObs span payloads to meet the new LLMObs evp public API requirements.
Existing tests should cover this change, and this is a completely internal change meaning there are no public-facing changes.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist