Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: NoneSpan #9549

Closed
wants to merge 6 commits into from
Closed

chore: NoneSpan #9549

wants to merge 6 commits into from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jun 14, 2024

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 14, 2024

Datadog Report

Branch report: gnufede/none-span
Commit report: 6400a57
Test service: dd-trace-py

❌ 138 Failed (1 Known Flaky), 170895 Passed, 1456 Skipped, 9h 33m 16.72s Total duration (14.71s time saved)

❌ Failed Tests (138)

This report shows up to 5 failed tests.

  • test_global_tags - test_anthropic.py - Details

    Expand for error
     assert None == '1234'
      +  where None = <bound method Span.get_tag of <Span(id=7137336017373173925,trace_id=136144124682424896211255454062460344022,parent_id=None,name=anthropic.request)>>('version')
      +    where <bound method Span.get_tag of <Span(id=7137336017373173925,trace_id=136144124682424896211255454062460344022,parent_id=None,name=anthropic.request)>> = <Span(id=7137336017373173925,trace_id=136144124682424896211255454062460344022,parent_id=None,name=anthropic.request)>.get_tag
    
  • test_global_tags - test_anthropic.py - Details

    Expand for error
     assert None == '1234'
      +  where None = <bound method Span.get_tag of <Span(id=6069037275658086349,trace_id=136144124523968571169140202270408736593,parent_id=None,name=anthropic.request)>>('version')
      +    where <bound method Span.get_tag of <Span(id=6069037275658086349,trace_id=136144124523968571169140202270408736593,parent_id=None,name=anthropic.request)>> = <Span(id=6069037275658086349,trace_id=136144124523968571169140202270408736593,parent_id=None,name=anthropic.request)>.get_tag
    
  • test_global_tags - test_anthropic.py - Details

    Expand for error
     assert None == '1234'
      +  where None = <bound method Span.get_tag of <Span(id=16030667971859530939,trace_id=136144124761653058715971394940119320107,parent_id=None,name=anthropic.request)>>('version')
      +    where <bound method Span.get_tag of <Span(id=16030667971859530939,trace_id=136144124761653058715971394940119320107,parent_id=None,name=anthropic.request)>> = <Span(id=16030667971859530939,trace_id=136144124761653058715971394940119320107,parent_id=None,name=anthropic.request)>.get_tag
    
  • test_global_tags_async - test_anthropic.py - Details

    Expand for error
     assert None == '1234'
      +  where None = <bound method Span.get_tag of <Span(id=14113590107117871279,trace_id=136144124682424896213847665902879532347,parent_id=None,name=anthropic.request)>>('version')
      +    where <bound method Span.get_tag of <Span(id=14113590107117871279,trace_id=136144124682424896213847665902879532347,parent_id=None,name=anthropic.request)>> = <Span(id=14113590107117871279,trace_id=136144124682424896213847665902879532347,parent_id=None,name=anthropic.request)>.get_tag
    
  • test_global_tags_async - test_anthropic.py - Details

    Expand for error
     assert None == '1234'
      +  where None = <bound method Span.get_tag of <Span(id=18434801961955621655,trace_id=136144124603196733696578444010266513242,parent_id=None,name=anthropic.request)>>('version')
      +    where <bound method Span.get_tag of <Span(id=18434801961955621655,trace_id=136144124603196733696578444010266513242,parent_id=None,name=anthropic.request)>> = <Span(id=18434801961955621655,trace_id=136144124603196733696578444010266513242,parent_id=None,name=anthropic.request)>.get_tag
    

@gnufede gnufede changed the title wip chore: NoneSpan Jun 14, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 14, 2024

Benchmarks

Benchmark execution time: 2024-06-14 16:39:22

Comparing candidate commit 6400a57 in PR branch gnufede/none-span with baseline commit 128b80d in branch main.

Found 0 performance improvements and 11 performance regressions! Performance is the same for 210 metrics, 9 unstable metrics.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+4.039µs; +4.140µs] or [+37.863%; +38.807%]

scenario:httppropagationinject-with_all

  • 🟥 execution_time [+5.075µs; +5.243µs] or [+21.620%; +22.337%]

scenario:httppropagationinject-with_dd_origin

  • 🟥 execution_time [+4.694µs; +4.822µs] or [+30.008%; +30.827%]

scenario:httppropagationinject-with_priority_and_origin

  • 🟥 execution_time [+4.750µs; +4.956µs] or [+26.927%; +28.091%]

scenario:httppropagationinject-with_sampling_priority

  • 🟥 execution_time [+4.072µs; +4.184µs] or [+31.883%; +32.757%]

scenario:httppropagationinject-with_tags

  • 🟥 execution_time [+5.042µs; +5.291µs] or [+29.341%; +30.789%]

scenario:httppropagationinject-with_tags_invalid

  • 🟥 execution_time [+5.295µs; +5.537µs] or [+26.851%; +28.077%]

scenario:httppropagationinject-with_tags_max_size

  • 🟥 execution_time [+5.008µs; +5.204µs] or [+28.605%; +29.727%]

scenario:span-start-finish

  • 🟥 execution_time [+4.375ms; +5.331ms] or [+7.834%; +9.545%]

scenario:span-start-finish-telemetry

  • 🟥 execution_time [+4.569ms; +5.538ms] or [+8.003%; +9.701%]

scenario:span-start-finish-traceid128

  • 🟥 execution_time [+4.331ms; +5.425ms] or [+7.305%; +9.150%]

@gnufede gnufede closed this Jun 19, 2024
@gnufede gnufede deleted the gnufede/none-span branch June 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant