-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(django): add dbm trace propagation for django postgres #9601
Conversation
BenchmarksBenchmark execution time: 2024-06-27 16:14:19 Comparing candidate commit 8ba3a04 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
…/dd-trace-py into conti/fix-django-dbm-propagation
…/dd-trace-py into conti/fix-django-dbm-propagation
Datadog ReportBranch report: ✅ 0 Failed, 130365 Passed, 46266 Skipped, 6h 10m 26.1s Total duration (4h 23m 31.41s time saved) |
…/dd-trace-py into conti/fix-django-dbm-propagation
releasenotes/notes/implement-django-postgres-dbm-trace-propagation-6ed725516d8bc5c1.yaml
Outdated
Show resolved
Hide resolved
…tlangdon/dbm.listeners
…/dd-trace-py into conti/fix-django-dbm-propagation
adding @emmettbutler to review the changes I made to core API. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9601 +/- ##
===========================================
- Coverage 74.65% 10.16% -64.49%
===========================================
Files 1381 1351 -30
Lines 127965 126079 -1886
===========================================
- Hits 95531 12819 -82712
- Misses 32434 113260 +80826 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core changes make sense to me
Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Datadog ReportBranch report: ✅ 0 Failed, 118418 Passed, 58274 Skipped, 4h 31m 23.96s Total duration (5h 21m 11.37s time saved) |
Closes: #8239
This PR implements DBM trace propagation for postgres database usage through django.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist