chore(llmobs): backport token metric key name changes to 2.10 #9808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the following updates to metric key names submitted to LLM Observability for openai & bedrock integrations `prompt_tokens` -> `input_tokens` `completion_tokens` -> `output_tokens` The backend already has the changes in place to accept these updated key names so a hard cutover is OK. A release note is not needed since metric key names used by our integrations (openai, langchain, bedrock) when submitting data to LLM Obs backend is an internal contract between the integration and backend. When users set metric key names for manually created spans, our documentation already instructs them to use input/output terminology - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: lievan <evan.li@datadoqhq.com> Co-authored-by: kyle <kyle@verhoog.ca>
lievan
added
the
changelog/no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 1469 Passed, 38933 Skipped, 37m 23.44s Total duration (1h 41m 30.78s time saved) |
BenchmarksBenchmark execution time: 2024-07-12 20:48:48 Comparing candidate commit e3a2197 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics. |
|
@erikayasuda @emmettbutler why is apm-core-python a required reviewer for this PR? 😕 |
It's this 😞 https://github.com/DataDog/dd-trace-py/blob/main/.github/CODEOWNERS#L97 |
erikayasuda
approved these changes
Jul 12, 2024
Yun-Kim
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport for #9657 to 2.10
Backport allows us to remove logic in the backend which parses both (prompt/completion_tokens) and (input/output_tokens) keys
Checklist
Reviewer Checklist