Remove default from comma_separated_only argument

DataDog · May 11, 2022 · 23af51b · 23af51b
1 parent 3a557ae
commit 23af51b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/datadog/core/configuration/settings.rb b/lib/datadog/core/configuration/settings.rb
@@ -305,7 +305,7 @@ def initialize(*_)
             tags = {}
 
             # Parse tags from environment
-            env_to_list(Core::Environment::Ext::ENV_TAGS).each do |tag|
+            env_to_list(Core::Environment::Ext::ENV_TAGS, comma_separated_only: false).each do |tag|
               pair = tag.split(':')
               tags[pair.first] = pair.last if pair.length == 2
             end

diff --git a/lib/datadog/core/environment/variable_helpers.rb b/lib/datadog/core/environment/variable_helpers.rb
@@ -33,15 +33,15 @@ def env_to_float(var, default = nil)
         # either trailing or leading are trimmed.
         #
         # Empty entries, after trimmed, are also removed from the result.
-        def env_to_list(var, default = [], comma_separated_only: false)
+        def env_to_list(var, default = [], comma_separated_only:)
           var = decode_array(var)
           if var && ENV.key?(var)
             value = ENV[var]
 
             values = if value.include?(',') || comma_separated_only
                        value.split(',')
                      else
-                       value.split # space splitting is the default
+                       value.split(' ') # rubocop:disable Style/RedundantArgument
                      end
 
             values.map! do |v|

diff --git a/spec/datadog/core/environment/variable_helpers_spec.rb b/spec/datadog/core/environment/variable_helpers_spec.rb
@@ -158,15 +158,15 @@
   end
 
   describe '::env_to_list' do
-    subject(:env_to_list) { variable_helpers.env_to_list(var) }
+    subject(:env_to_list) { variable_helpers.env_to_list(var, comma_separated_only: false) }
 
     context 'when env var is not defined' do
       context 'and default is not defined' do
         it { is_expected.to eq([]) }
       end
 
       context 'and default is defined' do
-        subject(:env_to_list) { variable_helpers.env_to_list(var, default) }
+        subject(:env_to_list) { variable_helpers.env_to_list(var, default, comma_separated_only: false) }
 
         let(:default) { double }