Only allow base 10 numbers

DataDog · Dec 15, 2023 · b3e8f7c · b3e8f7c
1 parent 9eeb431
commit b3e8f7c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/datadog/core/configuration/option.rb b/lib/datadog/core/configuration/option.rb
@@ -196,7 +196,7 @@ def coerce_env_variable(value)
 
         def coerce_env_var_int(value)
           # Strict integer parsing
-          Integer(value)
+          Integer(value, 10)
         rescue ArgumentError => e
           # Try also parsing as a whole floating point numbers
           begin

diff --git a/spec/datadog/core/configuration/option_spec.rb b/spec/datadog/core/configuration/option_spec.rb
@@ -648,6 +648,13 @@
             expect(option.get).to eq 1234
           end
 
+          context 'with an octal number' do
+            let(:env_value) { '010' }
+            it 'parses in base 10' do
+              expect(option.get).to eq 10
+            end
+          end
+
           context 'with a whole float' do
             let(:env_value) { '10.0' }
             it 'coerce value' do