Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI environment variables parsing #1763

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

fermayo
Copy link
Contributor

@fermayo fermayo commented Nov 7, 2021

Fixes #1745

Updated CI environment variables parsing algorithm with latest specification.

@fermayo fermayo added bug Involves a bug ci-app CI product for test suite instrumentation labels Nov 7, 2021
@fermayo fermayo requested review from a team November 7, 2021 21:58
@codecov-commenter
Copy link

Codecov Report

Merging #1763 (e6d4447) into master (1217a07) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         931      931           
  Lines       44868    44869    +1     
=======================================
+ Hits        44067    44068    +1     
  Misses        801      801           
Impacted Files Coverage Δ
lib/datadog/ci/ext/environment.rb 98.85% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1217a07...e6d4447. Read the comment docs.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcotc marcotc merged commit b57cac6 into master Nov 8, 2021
@marcotc marcotc deleted the fermayo/ciapp-update-ci-env-parsing branch November 8, 2021 19:38
@github-actions github-actions bot added this to the 0.54.0 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug ci-app CI product for test suite instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git branch not detected from Buildkite CI environment
4 participants