AppSec: resist missing ruleset file #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
changed the title
lloeki
force-pushed
the
appsec-resist-missing-file
branch
6 times, most recently
from
2ec2f05
to
33b4196
Compare
lloeki
commented
Mar 25, 2022
ivoanjo
reviewed
Mar 29, 2022
|
Addressed some (though not all yet) of the review comments. |
ivoanjo
approved these changes
Apr 5, 2022
Adjusts the behaviour from raising an exception to outputting an error and allow the app to continue running. This also generalises the error management beyond a ruleset file being missing and also takes into account various invalid ruleset cases or libddwaf unavailability. In these cases, in addition to the error, a warning is produced that alerts the user that AppSec is subsequently disabled.
lloeki
force-pushed
the
appsec-resist-missing-file
branch
from
5e09e4f
to
42a0752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the behaviour from raising an exception to outputting an error and allow the app to continue running. This also generalises the error management beyond a ruleset file being missing and also takes into account various invalid ruleset cases or libddwaf unavailability.
In these cases, in addition to the error, a warning is produced that alerts the user that AppSec is subsequently disabled.