Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for space-separated DD_TAGS #1953

Closed
ivoanjo opened this issue Mar 31, 2022 · 0 comments · Fixed by #2011
Closed

Missing support for space-separated DD_TAGS #1953

ivoanjo opened this issue Mar 31, 2022 · 0 comments · Fixed by #2011
Labels
core Involves Datadog core libraries

Comments

@ivoanjo
Copy link
Member

ivoanjo commented Mar 31, 2022

This seems to be a less well-known feature, but even back as January 2018 the datadog agent allowed tags in DD_TAGS to be space instead of comma-separated: DataDog/datadog-agent#1071 .

This was fixed in dd-trace-java in 2020: DataDog/dd-trace-java#2011 and in dd-trace-py in 2021: DataDog/dd-trace-py#2195 .

No customers have reported this for dd-trace-rb, but it looks like a nice win for consistency across Datadog libraries.
@ivoanjo ivoanjo added the core Involves Datadog core libraries label Mar 31, 2022
@marcotc marcotc mentioned this issue May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support spaces in environment variable lists DataDog/dd-trace-rb
1 participant
@ivoanjo