Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rulesets to v1.3.1 #1965

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Update rulesets to v1.3.1 #1965

merged 1 commit into from
Apr 6, 2022

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Apr 5, 2022

This updates to a ruleset version supporting detection of spring4shell attacks, although detecting it requires the server.request.body address, which is not yet implemented.

@lloeki lloeki requested a review from a team April 5, 2022 14:15
@codecov-commenter
Copy link

Codecov Report

Merging #1965 (45860d9) into master (ad258c4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1965   +/-   ##
=======================================
  Coverage   97.65%   97.66%           
=======================================
  Files         998      998           
  Lines       50291    50293    +2     
=======================================
+ Hits        49112    49117    +5     
+ Misses       1179     1176    -3     
Impacted Files Coverage Δ
spec/datadog/profiling/ext/forking_spec.rb 100.00% <0.00%> (+0.60%) ⬆️
lib/datadog/core/diagnostics/environment_logger.rb 100.00% <0.00%> (+1.58%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@lloeki lloeki merged commit 2ed82eb into master Apr 6, 2022
@lloeki lloeki deleted the update-rulesets-to-1.3.1 branch April 6, 2022 10:08
@github-actions github-actions bot added this to the 1.0.0.beta2 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants