Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional :tracer settings to 1.0 upgrade guide #1973

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 12, 2022

A few of these very old tracer settings were deprecated, removed but not described in the upgrade guide. This pull request adds a description of them, and an alternative in 1.x.

@delner delner added the docs Involves documentation label Apr 12, 2022
@delner delner added this to the 1.0.0.beta2 milestone Apr 12, 2022
@delner delner self-assigned this Apr 12, 2022
@delner delner requested a review from a team April 12, 2022 13:29
Copy link
Contributor

@lloeki lloeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, save for a small stray |.

docs/UpgradeGuide.md Outdated Show resolved Hide resolved
@delner delner force-pushed the docs/upgrade_guide_tracer_options branch from a6743f3 to d45b555 Compare April 12, 2022 16:45
@delner delner added this to Reviewer approved in 1.0 Apr 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1973 (d45b555) into master (60ecc8a) will increase coverage by 0.15%.
The diff coverage is 93.68%.

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   97.53%   97.69%   +0.15%     
==========================================
  Files         998     1000       +2     
  Lines       49006    50445    +1439     
==========================================
+ Hits        47800    49283    +1483     
+ Misses       1206     1162      -44     
Impacted Files Coverage Δ
.../datadog/appsec/contrib/rack/request_middleware.rb 34.48% <25.00%> (+10.95%) ⬆️
lib/datadog/appsec/processor.rb 86.20% <86.20%> (ø)
spec/datadog/core/error_spec.rb 94.02% <90.00%> (-0.38%) ⬇️
spec/datadog/appsec/processor_spec.rb 100.00% <100.00%> (ø)
spec/datadog/profiling/ext/forking_spec.rb 99.39% <0.00%> (-0.61%) ⬇️
lib/datadog/ci/test.rb 100.00% <0.00%> (ø)
lib/datadog/ci/flush.rb 100.00% <0.00%> (ø)
lib/datadog/profiling.rb 100.00% <0.00%> (ø)
spec/datadog/core_spec.rb 100.00% <0.00%> (ø)
lib/ddtrace/transport/io.rb 100.00% <0.00%> (ø)
... and 211 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@delner delner merged commit 1e006a2 into master Apr 12, 2022
@delner delner deleted the docs/upgrade_guide_tracer_options branch April 12, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
1.0
Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

3 participants