Bootstrap Ruby 3.2.0-preview1 testing #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
commented
Apr 12, 2022
Comment on lines
811
to
+828
| - orb/build_and_test_integration: | ||
| name: build_and_test_integration-2.5 | ||
| integration_apps: 'rack rails-five' | ||
| integration_apps: 'rack rails-five rails-six' | ||
| ruby_version: '2.5' | ||
| <<: *filters_all_branches_and_tags | ||
| - orb/build_and_test_integration: | ||
| name: build_and_test_integration-2.6 | ||
| integration_apps: 'rack rails-five' | ||
| integration_apps: 'rack rails-five rails-six' | ||
| ruby_version: '2.6' | ||
| <<: *filters_all_branches_and_tags | ||
| - orb/build_and_test_integration: | ||
| name: build_and_test_integration-2.7 | ||
| integration_apps: 'rack rails-five' | ||
| integration_apps: 'rack rails-five rails-six rails-seven' | ||
| ruby_version: '2.7' | ||
| <<: *filters_all_branches_and_tags | ||
| - orb/build_and_test_integration: | ||
| name: build_and_test_integration-3.0 | ||
| # Note: Ruby 3 is not supported by Rails 5, hence we skip it | ||
| integration_apps: 'rack' | ||
| integration_apps: 'rack rails-six rails-seven' |
There was a problem hiding this comment.
This was actually missing! (unrelated to 3.2 addition)
ivoanjo
commented
Apr 12, 2022
| docker build --build-arg BASE_IMAGE=datadog/dd-apm-demo:rb-3.1 -t datadog/dd-apm-demo:rb-3.1-rspec . | ||
| docker build --build-arg BASE_IMAGE=datadog/dd-apm-demo:rb-3.1 -t datadog/dd-apm-demo:rb-3.1-ruby . |
There was a problem hiding this comment.
This was actually incorrect for 3.1
ivoanjo
commented
Apr 12, 2022
ivoanjo
force-pushed
the
ivoanjo/bootstrap-ruby-3-2
branch
from
e196ea6
to
2be18a2
Compare
marcotc
approved these changes
Apr 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the ground work of testing with Ruby 3.2.0-preview1. I initially tried enabling it in CircleCI as well but:
Even without addressing them, I think having the docker image and being able to run these tests locally is a step towards fixing them, so I think this PR is still valuable.