Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to version 1.0.0 #1993

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Bump to version 1.0.0 #1993

merged 3 commits into from
Apr 29, 2022

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Apr 28, 2022 •
edited
Loading

🎉

@marcotc marcotc added the release Official release label Apr 28, 2022
@marcotc marcotc added this to the 1.0.0.beta3 milestone Apr 28, 2022
@marcotc marcotc self-assigned this Apr 28, 2022
@marcotc marcotc requested a review from a team April 28, 2022 19:41
lloeki
lloeki reviewed Apr 28, 2022
View reviewed changes
gemfiles/ruby_3.2.0_contrib_old.gemfile
@@ -37,5 +37,6 @@ gem "google-protobuf", ["~> 3.0", "!= 3.7.0", "!= 3.7.1"]
gem "sorbet", "= 0.5.9672"
gem "spoom", "~> 1.1"
gem "dalli", "< 3.0.0"
gem "graphql", ">= 1.12.0", "< 2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if this was expected in this changeset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #1993 (comment) 😄

gemfiles/ruby_3.2.0_contrib.gemfile
gem "graphql", ">= 1.12.0", "< 1.13.0"
gem "graphql", ">= 2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if these were expected in this changeset.

Copy link
Member

@ivoanjo ivoanjo Apr 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can explain this one:

  1. Bootstrap Ruby 3.2.0-preview1 testing #1974 and Add support for GraphQL 2.0 #1982 were opened concurrently
  2. I merged Bootstrap Ruby 3.2.0-preview1 testing #1974 first
  3. I suggested Marco not to bother updating the gemfiles/ for 3.2 on his PR as anyway they don't run in CircleCI yet (Add support for GraphQL 2.0 #1982 (comment))
  4. The changes showed up here when Marco run the command to update all gemfiles

So this is 100% harmless :)

ivoanjo
ivoanjo approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marcotc marcotc merged commit a89d2b2 into master Apr 29, 2022
@marcotc marcotc deleted the bump_to_version_1.0.0 branch April 29, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloeki lloeki lloeki approved these changes

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees

@marcotc marcotc

Labels
release Official release
Projects
1.0
Awaiting triage
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcotc @lloeki @ivoanjo