Fix service_nam typo to service_name

[jackweinbender]

Just a simple typo fix in the configuration file of the Graphql integration. I don't know if this is the source of some of my recent issues, but if the option is going to be there... it should be right.

[codecov-commenter]

Codecov Report

Merging #2296 (06ef469) into master (bea1360) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
- Coverage   97.58%   97.57%   -0.02%     
==========================================
  Files        1094     1094              
  Lines       57394    57392       -2     
==========================================
- Hits        56010    55999      -11     
- Misses       1384     1393       +9     

Impacted Files	Coverage Δ
.../tracing/contrib/graphql/configuration/settings.rb	100.00% <100.00%> (ø)
...ontrib/sidekiq/server_internal_tracer/heartbeat.rb	36.00% <0.00%> (-28.00%)	⬇️
lib/datadog/core/workers/polling.rb	96.55% <0.00%> (-3.45%)	⬇️
lib/datadog/core/diagnostics/environment_logger.rb	98.41% <0.00%> (-1.59%)	⬇️
...adog/tracing/contrib/sidekiq/client_tracer_spec.rb	100.00% <0.00%> (+2.08%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[marcotc]

Thank you, @jackweinbender!

Funny enough, because Datadog::Tracing::Contrib::GraphQL::Configuration::Settings inherits from Datadog::Tracing::Contrib::Configuration::Settings, which contains:

dd-trace-rb/lib/datadog/tracing/contrib/configuration/settings.rb

Line 22 in bea1360

option :service_name

The service_name setting is actually working as expected, despite the typo:

require 'ddtrace'
Datadog::Tracing::Contrib::GraphQL::Configuration::Settings.instance_methods.select{|x|x.start_with?('service_name')}
# => [:service_name=, :service_name]

Your changes are still welcome, as we'd like to have precise tracking of which integrations explicit want a service_name configuration vs integrations that only have it because it's the default behavior.

[lloeki]

Hey @jackweinbender, this change was just released in v1.5.0!