128 bits trace id #2543
Merged
128 bits trace id #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/128bits-trace-id-propagation
branch
from
f9b081a
to
82c343e
Compare
TonyCTHsu
force-pushed
the
tonycthsu/128bits-trace-id-propagation
branch
from
f97fbf3
to
7396eb3
Compare
TonyCTHsu
force-pushed
the
tonycthsu/128bits-trace-id-propagation
branch
from
7396eb3
to
4f8a8ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
==========================================
+ Coverage 98.08% 98.09% +0.01%
==========================================
Files 1166 1166
Lines 63832 64198 +366
Branches 2849 2861 +12
==========================================
+ Hits 62607 62974 +367
+ Misses 1225 1224 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 2, 2023
| @@ -47,6 +47,7 @@ def format! | |||
| tag_rate_limiter_rate! | |||
| tag_sample_rate! | |||
| tag_sampling_decision_maker! | |||
| tag_high_order_trace_id! | |||
There was a problem hiding this comment.
We should also adjust the the span.trace_id on all spans in the TraceFormatter, so the TraceFormatter always makes sure the TraceSegment provided is ready to be serialized without any changes.
This simplifies the serializer's logic.
There was a problem hiding this comment.
I actually hesitate to commit to this change since TraceFormatter is performing at the trace level attributes which is a constraint of agent's API. I would prefer the current approach of decorating SerailizableSpan than mutating Span from TraceFormatter.
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 2, 2023
marcotc
reviewed
Mar 3, 2023
TonyCTHsu
force-pushed
the
tonycthsu/128bits-trace-id-propagation
branch
from
86ca9af
to
0aab0da
Compare
TonyCTHsu
force-pushed
the
tonycthsu/128bits-trace-id-propagation
branch
from
0aab0da
to
c9ea54b
Compare
marcotc
approved these changes
Mar 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support 128-bit trace id. With this change, our trace is backward compatible with 128-bit trace id, which is used for W3C trace context and b3 propagation.
DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLEDDD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED(Not yet supported)