128 bits trace id - #2543
Conversation
f9b081a to
82c343e
Compare
f97fbf3 to
7396eb3
Compare
7396eb3 to
4f8a8ad
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2543 +/- ##
==========================================
+ Coverage 98.08% 98.09% +0.01%
==========================================
Files 1166 1166
Lines 63832 64198 +366
Branches 2849 2861 +12
==========================================
+ Hits 62607 62974 +367
+ Misses 1225 1224 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| tag_rate_limiter_rate! | ||
| tag_sample_rate! | ||
| tag_sampling_decision_maker! | ||
| tag_high_order_trace_id! |
There was a problem hiding this comment.
We should also adjust the the span.trace_id on all spans in the TraceFormatter, so the TraceFormatter always makes sure the TraceSegment provided is ready to be serialized without any changes.
This simplifies the serializer's logic.
There was a problem hiding this comment.
I actually hesitate to commit to this change since TraceFormatter is performing at the trace level attributes which is a constraint of agent's API. I would prefer the current approach of decorating SerailizableSpan than mutating Span from TraceFormatter.
86ca9af to
0aab0da
Compare
0aab0da to
c9ea54b
Compare
What does this PR do?
Support 128-bit trace id. With this change, our trace is backward compatible with 128-bit trace id, which is used for W3C trace context and b3 propagation.
DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLEDDD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED(Not yet supported)