Add support for GET in transport #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
reviewed
Mar 8, 2023
lloeki
force-pushed
the
add-get-support-to-transport
branch
from
ce078a1
to
97e3930
Compare
Some endpoints respond to GET, which was not implemented. In addition, since GET can't have a body, a `Request` parcel can be omitted. It is therefore made optional.
lloeki
force-pushed
the
add-get-support-to-transport
branch
from
97e3930
to
134308e
Compare
|
Rebased to fix CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement GET support for HTTP transport.
Motivation
Some endpoints respond to GET, which was not implemented.
Additional Notes
In addition, since GET can't have a body, a
Requestparcel can be omitted. It is therefore made optional.How to test the change?
CI should be green.