-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote configuration repository #2688
Conversation
Pending:
|
7c70894
to
37eb3b0
Compare
339af0f
to
414a626
Compare
Rebased using |
This is an initial basic implementation. It is notably missing: - storing digests for each bit of content - reporting a summary of which paths have been updated and their corresponding data for taking action on the newly received configuration - error tracking and reporting - a content caching mechanism and cache state reporting These will be added progressively.
414a626
to
5371edf
Compare
Rebased using |
914ad97
to
92ee072
Compare
92ee072
to
059817d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the specs and types! I have a suggestion concerning Base
.
Codecov Report
@@ Coverage Diff @@
## master #2688 +/- ##
==========================================
- Coverage 98.09% 98.03% -0.07%
==========================================
Files 1168 1197 +29
Lines 64254 65714 +1460
Branches 2857 2926 +69
==========================================
+ Hits 63033 64423 +1390
- Misses 1221 1291 +70
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What does this PR do?
Add configuration repository, using PORO from #2687
Motivation
Additional Notes
This is an initial basic implementation. It is notably missing:
These will be added progressively.
How to test the change?