-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote configuration changeset #2696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
reviewed
Mar 17, 2023
lloeki
force-pushed
the
add-remote-config-changeset
branch
from
March 20, 2023 15:45
8950105
to
904ca43
Compare
lloeki
force-pushed
the
add-remote-config-component
branch
from
March 21, 2023 10:27
5b0d4d0
to
6fbc961
Compare
lloeki
force-pushed
the
add-remote-config-changeset
branch
from
March 21, 2023 10:28
904ca43
to
8c7212d
Compare
lloeki
force-pushed
the
add-remote-config-component
branch
from
March 21, 2023 13:37
6fbc961
to
1bf6a5d
Compare
lloeki
force-pushed
the
add-remote-config-changeset
branch
from
March 21, 2023 13:37
8c7212d
to
aa89610
Compare
GustavoCaso
force-pushed
the
add-remote-config-component
branch
from
March 21, 2023 16:26
76a7c15
to
d7bca7b
Compare
GustavoCaso
force-pushed
the
add-remote-config-changeset
branch
from
March 21, 2023 16:34
aa89610
to
f03c058
Compare
GustavoCaso
force-pushed
the
add-remote-config-component
branch
from
March 22, 2023 08:59
d7bca7b
to
9749b5b
Compare
GustavoCaso
force-pushed
the
add-remote-config-changeset
branch
from
March 22, 2023 10:13
f03c058
to
9692f2e
Compare
GustavoCaso
force-pushed
the
add-remote-config-changeset
branch
from
March 22, 2023 10:34
9692f2e
to
7ccbbb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2696 +/- ##
=======================================
Coverage 98.05% 98.06%
=======================================
Files 1208 1208
Lines 66246 66340 +94
Branches 2961 2969 +8
=======================================
+ Hits 64960 65056 +96
+ Misses 1286 1284 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GustavoCaso
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a reporting of which paths were touched, what the content was before and what it is after the transaction.
Motivation
Remote configuration.
Contrary to transactions which are a sequential list of operations to apply in order, for mutative usage internal to the repository, a changeset is a report of state change, for a consumer external to the repository (more precisely the upcoming dispatcher).
Additional Notes
Using an
Array
-basedContentList
may not be the most optimal data structure. I am considering changing it to aHash
-basedContentMap
instead in the future. Nonetheless,ContentList
does the job for this PR.How to test the change?