[PROF-6555] Support disabling endpoint names collection in new profiler #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR updates the new CPU Profiling 2.0 profiler to honor the existing `profiling.advanced.endpoint.collection.enabled` setting. This setting defaults to enabled. When disabled, the profiler will omit endpoint names in the collected data. **Motivation**: Not supporting this was an oversight; the new profiler (still in beta) should honor this setting. **Additional Notes**: N/A **How to test the change?**: Change includes test coverage.
ivoanjo
commented
Mar 17, 2023
| @@ -911,6 +932,8 @@ static void trace_identifiers_for(struct thread_context_collector_state *state, | |||
|
|
|||
| trace_identifiers_result->valid = true; | |||
|
|
|||
| if (!state->endpoint_collection_enabled) return; | |||
There was a problem hiding this comment.
All this setup and passing the setting around just to do this ;)
marcotc
approved these changes
Mar 17, 2023
Base automatically changed from
ivoanjo/prof-6555-decouple-profiling-initialization
to
master
March 17, 2023 19:15
Unfortunately not caught by the spec either :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR updates the new CPU Profiling 2.0 profiler to honor the existing
profiling.advanced.endpoint.collection.enabledsetting.This setting defaults to enabled. When disabled, the profiler will omit endpoint names in the collected data.
Motivation:
Not supporting this was an oversight; the new profiler (still in beta) should honor this setting.
Additional Notes:
I'm opening this PR on top of #2697 to avoid conflicts, but both PRs are conceptually independent.
How to test the change?:
Change includes test coverage.