Add response headers passing to WAF #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
lloeki
force-pushed
the
appsec-rack-response-headers
branch
3 times, most recently
from
3815cbb
to
d70a0f2
Compare
|
System tests seem to actually lack a test for that. Rulesets don't even include a rule for this WAF address. |
lloeki
force-pushed
the
appsec-rack-response-headers
branch
from
d70a0f2
to
55818e7
Compare
lloeki
force-pushed
the
appsec-rack-response-headers
branch
from
55818e7
to
7dce952
Compare
Codecov Report
@@ Coverage Diff @@
## master #2701 +/- ##
=======================================
Coverage 98.06% 98.07%
=======================================
Files 1222 1222
Lines 67271 67277 +6
Branches 3013 3013
=======================================
+ Hits 65972 65980 +8
+ Misses 1299 1297 -2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Propagate Rack response headers to the WAF
Motivation
Suspicious request blocking
Additional Notes
Nope
How to test the change?
System tests + CI