Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Span Attribute Schema Environment Variable #2727

Merged
merged 15 commits into from
Apr 5, 2023
Merged

Implement Span Attribute Schema Environment Variable #2727

merged 15 commits into from
Apr 5, 2023

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Mar 28, 2023 •
edited

What does this PR do?

For future modifications to the repo, we will depend on the usage of a schema version to enable certain features. This includes enabling the default service_name to DD_SERVICE. This repo adds the following:

  • DD_TRACE_SPAN_ATTRIBUTE_SCHEMA env variable to enable future service name changes
  • Adds new v1 service naming functionality in the AWS integration as a first integration test by changing service name defaults
  • Adds unit testing for all new changes

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Mar 28, 2023
@zarirhamza zarirhamza marked this pull request as ready for review March 30, 2023 20:04
@zarirhamza zarirhamza requested a review from a team March 30, 2023 20:04
@zarirhamza zarirhamza marked this pull request as draft April 3, 2023 15:46
@zarirhamza zarirhamza marked this pull request as ready for review April 3, 2023 16:05
marcotc
marcotc reviewed Apr 4, 2023
View reviewed changes
.rubocop_todo.yml Outdated Show resolved Hide resolved
@zarirhamza zarirhamza changed the title Service Name Changes Part 1 Implement Span Attribute Schema Environment Variable Apr 5, 2023
@marcotc marcotc merged commit c579124 into master Apr 5, 2023
52 checks passed
@marcotc marcotc deleted the zarir/servicename-env-var-aws branch April 5, 2023 18:16
@github-actions github-actions bot added this to the 1.11.0 milestone Apr 5, 2023
@lloeki lloeki modified the milestones: 1.11.0, 1.11.0.beta1 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@TonyCTHsu TonyCTHsu TonyCTHsu approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Milestone
1.11.0.beta1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zarirhamza @marcotc @TonyCTHsu @lloeki