Check info endpoint for remote configuration availability in the agent #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
force-pushed
the
check-info-endpoint-for-config-availability
branch
from
a89ee56
to
8160c00
Compare
ivoanjo
reviewed
Apr 14, 2023
lib/datadog/core/remote/component.rb
Outdated
Comment on lines
28
to
36
| Datadog.logger.error do | ||
| 'agent reachable but does not report remote configuration endpoint: ' \ | ||
| 'disabling remote configuration for this process.' | ||
| end |
There was a problem hiding this comment.
Since this is a user-visible message, consider perhaps suggesting that users upgrade their agent to get rid of this message?
(Same for the unreachable message below -- perhaps tell them that something seems wrong and they'll probably not be able to report data?)
There was a problem hiding this comment.
Great point @ivoanjo
Since we are targeting this change for the beta release. We can improve the error message for the official release 😄
This avoids getting a partially initialized instance of component
lloeki
force-pushed
the
check-info-endpoint-for-config-availability
branch
from
8160c00
to
2795b2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check info endpoint for remote configuration availability in the agent
Motivation
RC should not even start if the agent is unreachable or not configured properly.
Additional Notes
This should also warn the user so that corrective action can be taken self-served.
How to test the change?
Either one of:
DD_REMOTE_CONFIGURATION_ENABLED=falseenv varAnd then start an app with
DD_REMOTE_CONFIGURATION_ENABLED=true