[APPSEC-8957] Populate remote client cached_target_files payload field #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
force-pushed
the
remote-populate-config-states
branch
from
84d7359
to
b2b6f18
Compare
GustavoCaso
force-pushed
the
remote-populate-config-states
branch
from
b2b6f18
to
0d50196
Compare
lloeki
approved these changes
Apr 13, 2023
- Make sure Digest.hexdigest rewinds data - Calculate repository state at initialize - Improve config_states generation - Rename Content#hash to Content#hexdigest
GustavoCaso
added a commit
that referenced
this pull request
Apr 14, 2023
On the previous PR #2771 we populate `config_states` but we wanted to populate `cached_target_files`. I validated this changes works against our system-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cached_target_filesfield intends to signal to the agent what files the tracer has seen and subsequent requests. We do not have to pull that information from the agent.We can retrieve that information from the
repository.contentsTo do that, we have to tweak a little the different remote configuration components. The
DigestandDigestListare no longer private classes underTarget.We will use the
Digestclass to compute the hash value of the content on demand and store that information on theContentinstances. That way, we do not have to calculate the hash of the content over an over.Another quick addition is adding support for
:sha512. The remote configuration backend supports hashing the content using that algorithm.